Skip to content

New features: #412 and #417 #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Sep 7, 2021
Merged

New features: #412 and #417 #418

merged 17 commits into from
Sep 7, 2021

Conversation

yruslan
Copy link
Collaborator

@yruslan yruslan commented Sep 6, 2021

  • Added support for VBVR record format (BDW+RDW)
  • Added support for D record format (ASCII text, multisegment)
  • F, V, VB, and D formats can now be specified using 'record_format' option

yruslan added 15 commits September 1, 2021 10:32
@yruslan
#412 Rename the class name to match the file name
98e2456
@yruslan
#412 Add unit tests for the existing implementation
9377e8b
@yruslan
#412 Add generic RDW/BDW decoder supporting adjustments and endiness
b737b3f
@yruslan
#412 Make VBVR record extractor to use generic RDW/BDW decoders
8a04358
@yruslan
#412 Add support for extended BDWs
97588ec
@yruslan
#412 Improve the implementation of VBVR raw record extractor
30ea187
@yruslan
#412 Add new options to specify VB record format.
b325e6d
@yruslan
#412 Update documentation.
b9396ed
@yruslan
#412 Use non-deprecated options everywhere.
0df5ab9
@yruslan
#412 Bump up the minor version number since breaking changes are intr…
f211443 
…oduced.
@yruslan
#412 Add missing license.
761679d
@yruslan
#412 Add a test suite for data that has VB record format.
3261ba6
@yruslan
#417 Add Support for record_format = D (ASCII text).
9237a91
@yruslan
#417 Update README.
88b81eb
@yruslan
Fix a compilation error on Scala 2.11
75d4ed0
This was linked to issues Sep 6, 2021
Custom record extractor implementation for VBVR data files, should it not use rawRecordExtractor? #412
Closed
Add support of record format 'D' - ASCII text #417
Closed
zwessels
zwessels approved these changes Sep 6, 2021
View reviewed changes
@yruslan yruslan merged commit 212ce3d into master Sep 7, 2021
@yruslan yruslan deleted the feature/412-vbvr-record-support branch September 7, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@zwessels zwessels zwessels approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support of record format 'D' - ASCII text Custom record extractor implementation for VBVR data files, should it not use rawRecordExtractor?
2 participants
@yruslan @zwessels